Kevin Kuehler 4966b912c6 commands/account: Disable :view for deleted msgs ... Allowing the user to view deleted messages creates all sorts of race conditions. The most devious race condition is pv.source can be set to a nil while another PartViewer is still running a goroutine in attemptCopy. Here is a trace when this happens. goroutine 76 [running]: io.copyBuffer(0x7f8ad02641d0, 0xc00040f590, 0x0, 0x0, 0xc0007cc000, 0x8000, 0x8000, 0x0, 0x0, 0x8b3d60) /usr/lib/go/src/io/io.go:402 +0x101 io.Copy(...) /usr/lib/go/src/io/io.go:364 git.sr.ht/~sircmpwn/aerc/widgets.(*PartViewer).attemptCopy.func4(0xc00017efd0, 0xc0004da7c0) /home/keur/repos/aerc/widgets/msgviewer.go:576 +0x611 created by git.sr.ht/~sircmpwn/aerc/widgets.(*PartViewer).attemptCopy /home/keur/repos/aerc/widgets/msgviewer.go:544 +0x144 We could add a guard in store.FetchBodyPart to only call the callback when msg.Part.Reader != nil, but we still get a hanging pager. Therefore it seems more reasonable to disable this completely. Signed-off-by: Kevin Kuehler <keur@xcf.berkeley.edu>		2019-11-17 13:19:42 -05:00
..
account	commands/account: Disable :view for deleted msgs	2019-11-17 13:19:42 -05:00
compose	Add support for AUTH LOGIN submission	2019-11-01 11:02:01 -04:00
msg	Add Templates with Parsing	2019-11-10 10:15:49 -05:00
msgview	Cleanup pager processes after closing a msgviewer	2019-10-16 11:13:53 -04:00
terminal	all: purge redundant underscores	2019-09-04 16:30:57 -10:00
cd.go	Make commands join args with spaces	2019-09-20 15:06:34 -04:00
commands.go	Fix directory completion case sensitivity	2019-08-03 10:48:47 -04:00
ct.go	Make commands join args with spaces	2019-09-20 15:06:34 -04:00
exec.go	all: purge redundant underscores	2019-09-04 16:30:57 -10:00
global.go	Implement basic tab completion support	2019-06-29 14:24:19 -04:00
help.go	all: purge redundant underscores	2019-09-04 16:30:57 -10:00
history.go	Add command history and cycling	2019-07-26 14:29:34 -04:00
new-account.go	all: purge redundant underscores	2019-09-04 16:30:57 -10:00
next-tab.go	all: use fmt.Errorf for fomartting errors	2019-09-04 16:30:57 -10:00
prompt.go	all: use fmt.Errorf for fomartting errors	2019-09-04 16:30:57 -10:00
pwd.go	all: purge redundant underscores	2019-09-04 16:30:57 -10:00
quit.go	all: purge redundant underscores	2019-09-04 16:30:57 -10:00
set.go	all: purge redundant underscores	2019-09-04 16:30:57 -10:00
term.go	all: purge redundant underscores	2019-09-04 16:30:57 -10:00
util.go	Sort path completions	2019-09-20 15:07:05 -04:00