From b53cddb9f3b7f2898e0680f95ef4a97364d4f3a1 Mon Sep 17 00:00:00 2001 From: Bo-Yi Wu Date: Fri, 28 Jul 2017 21:32:21 +0800 Subject: [PATCH 1/2] default build or show last job Signed-off-by: Bo-Yi Wu --- drone/build/build_info.go | 2 +- drone/build/build_start.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drone/build/build_info.go b/drone/build/build_info.go index bc59398..f8c5ccd 100644 --- a/drone/build/build_info.go +++ b/drone/build/build_info.go @@ -36,7 +36,7 @@ func buildInfo(c *cli.Context) error { } var number int - if buildArg == "last" { + if buildArg == "last" || len(buildArg) == 0 { // Fetch the build number from the last build build, err := client.BuildLast(owner, name, "") if err != nil { diff --git a/drone/build/build_start.go b/drone/build/build_start.go index 4d46612..b75b175 100644 --- a/drone/build/build_start.go +++ b/drone/build/build_start.go @@ -39,7 +39,7 @@ func buildStart(c *cli.Context) (err error) { buildArg := c.Args().Get(1) var number int - if buildArg == "last" { + if buildArg == "last" || len(buildArg) == 0 { // Fetch the build number from the last build build, err := client.BuildLast(owner, name, "") if err != nil { From 4cd8882cc5ce36e3a25a9b0327fc026bff935ea1 Mon Sep 17 00:00:00 2001 From: Bo-Yi Wu Date: Fri, 28 Jul 2017 21:44:16 +0800 Subject: [PATCH 2/2] return error if missing arg on build start command. Signed-off-by: Bo-Yi Wu --- drone/build/build_start.go | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drone/build/build_start.go b/drone/build/build_start.go index b75b175..c986789 100644 --- a/drone/build/build_start.go +++ b/drone/build/build_start.go @@ -1,6 +1,7 @@ package build import ( + "errors" "fmt" "strconv" @@ -39,7 +40,7 @@ func buildStart(c *cli.Context) (err error) { buildArg := c.Args().Get(1) var number int - if buildArg == "last" || len(buildArg) == 0 { + if buildArg == "last" { // Fetch the build number from the last build build, err := client.BuildLast(owner, name, "") if err != nil { @@ -47,6 +48,9 @@ func buildStart(c *cli.Context) (err error) { } number = build.Number } else { + if len(buildArg) == 0 { + return errors.New("missing job number") + } number, err = strconv.Atoi(buildArg) if err != nil { return err